yuseok89 commented on code in PR #67242:
URL: https://github.com/apache/airflow/pull/67242#discussion_r3500083696
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx:
##########
@@ -179,19 +205,32 @@ const {
PAUSED,
}: SearchParamsKeysType = SearchParamsKeys;
-const cardDef: CardDef<DAGWithLatestDagRunsResponse> = {
- card: ({ row }) => <DagCard dag={row} />,
+const createCardDef = (runStateContext: RunStateCountsContext):
CardDef<DAGWithLatestDagRunsResponse> => ({
+ card: ({ row }) => (
+ <DagCard
+ dag={row}
+ runStateCounts={runStateContext.countsByDag[row.dag_id]}
+ runStateCountsLoading={runStateContext.isLoading}
+ stateCountLimit={runStateContext.stateCountLimit}
+ />
+ ),
meta: {
- customSkeleton: <Skeleton height="120px" width="100%" />,
+ customSkeleton: <Skeleton height="140px" width="100%" />,
},
-};
+});
+
+const DEFAULT_HOURS = "24";
export const DagsList = () => {
const { t: translate } = useTranslation();
const [searchParams, setSearchParams] = useSearchParams();
const [display, setDisplay] = useLocalStorage<"card" |
"table">(DAGS_LIST_DISPLAY_KEY, "card");
const dagRunsLimit = display === "card" ? 14 : 1;
+ const now = dayjs();
Review Comment:
This got removed naturally when I dropped the time range selector.
now and the two useState initialisers it fed are gone now.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
