yuseok89 commented on PR #67242: URL: https://github.com/apache/airflow/pull/67242#issuecomment-4894837635
> Thanks for the rework — all the earlier points are addressed and this looks ready. One small thing: the time-range selector was dropped from the Dags list (good), but the change to the shared `TimeRangeSelector.tsx` (the new `showDateRange` prop) doesn't seem to be used anywhere now. Could we revert that file so the shared component doesn't carry an unused prop? After that I think we're good to merge. > > > Also we rely on the 'list' refetching / being invalidated, to modify the 'useAutoRefresh' value and therefore trigger a refresh. If `auto_refresh_interval` is disabled, this will never refetch triggering a dag and the count will be stale. (Manual refresh will have to happen) Really grateful for how much time you put into this across so many iterations. Your early review on scalability was the turning point. It steered the whole approach somewhere much more solid, and I learned a lot from it. The unused `showDateRange` prop is gone from the shared `TimeRangeSelector` now. For the stale-count case when auto-refresh is off, I'll pick it up separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
