dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql
odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r362745659
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
> DbAPIHook provides SQL Alchemy engine but then we replace it with specific
libraries in the hooks that re-implement it.
DBAPI hook does not exactly provide an engine -- it just provides a standard
way to produce the engine given a URI. each hook may need to URI in different
way. but engine generation doesn't care about those details. so subclasses
have to override get_uri and system needs appropriate libraries and deps
installed.
EDIT: it sort of does do this. but the issue i think is it does not parse
`extra` in its `get_uri` method, so that's why we have to override get_uri in
subclasses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
