dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql
odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r363019151
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
Also, I am pretty sure everything that can be accomplished with pyodbc
connector can be achieved with this hook as presently designed because it
allows arbitrary ODBC properties to be included. Then this exact odbc
connection string is used in sqlalchemy connection string (see the get_uri
method in this PR). And you can modify other connection attributes after
creating the connection. So i think we're ok here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
