Dev-iL commented on code in PR #69089:
URL: https://github.com/apache/airflow/pull/69089#discussion_r3521835897


##########
providers/postgres/docs/changelog.rst:
##########
@@ -27,6 +27,20 @@
 Changelog
 ---------
 
+.. warning::
+    ``asyncpg`` is no longer installed by default — it moved to the 
``asyncpg`` optional extra, and
+    ``psycopg`` (psycopg3) is now installed by default as the async 
metadata-database driver. The
+    default derived async connection URL changed from 
``postgresql+asyncpg://`` to
+    ``postgresql+psycopg_async://``, which is safe behind transaction-mode 
PgBouncer with no extra
+    configuration. This aligns with the new default async Postgres driver in 
Airflow 3.4.0. To keep
+    using asyncpg, install ``apache-airflow-providers-postgres[asyncpg]`` and 
set
+    ``[database] sql_alchemy_conn_async = postgresql+asyncpg://...`` 
explicitly.
+
+    On Airflow versions before 3.4.0 the derived async URL always uses asyncpg 
(there is no psycopg3 fallback in core),
+    so on those versions this provider release requires either the ``asyncpg`` 
extra or an explicitly configured
+    ``[database] sql_alchemy_conn_async`` — otherwise the async 
metadata-database engine fails at startup with
+    ``ModuleNotFoundError: No module named 'asyncpg'``.

Review Comment:
   `changelog.rst` and `readme.rst` were updated to reflect the changes in 
extras.
   
   As for the version header - this is definitely a breaking change, and I too 
had the thought of adding a new header. However, [I inquired about exactly this 
on 
Slack](https://apache-airflow.slack.com/archives/C03G9H97MM2/p1782578285504629),
 and was told to make the breakage clear but leave versioning to the release 
managers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to