shahar1 opened a new pull request, #69377: URL: https://github.com/apache/airflow/pull/69377
A task whose trigger rule is `none_failed_min_one_success` and that lives inside a dynamically mapped task group was being **skipped before the task group expanded**, even though its upstream succeeded. The trigger rule is first evaluated on the task's not-yet-expanded *summary* task instance (`map_index -1`). By that point the upstream inside the same group has already expanded to `map_index 0..n`, so the summary-ti evaluation finds no relevant upstream successes, concludes "at least one success required, none found", and skips the task — it never expands. `one_success` / `one_failed` / `one_done` already avoid this by being treated as "fast-triggered" on the unexpanded summary ti (they depend on *all* upstream instances until the group expands — see #34023 / #50210). `none_failed_min_one_success` belongs in that same set: it can be satisfied by a subset of upstreams, so broad depend-on-all-upstreams counting on the summary ti is safe and lets the task expand normally. This PR adds it there. Reproduced on `main` (3.4.0) with the issue's minimal Dag (`tg.imawake` ended up `skipped` at `map_index -1` while `tg.imsleepy` expanded to `0,1,2` all success); with the fix `tg.imawake` expands to `0,1,2` and succeeds. Added a regression test that fails on the buggy code and passes with the fix. A prior attempt at this issue (#40428) was closed in 2024; this revives the fix scoped precisely to the affected trigger rule. closes: #39801 --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 4.8) Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
