This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 2629cf34ce2 UI: Load Monaco codicon glyph styles via direct CSS import 
(#69419)
2629cf34ce2 is described below

commit 2629cf34ce27ee51430e62d968df46d034ea9e08
Author: Jarek Potiuk <[email protected]>
AuthorDate: Mon Jul 6 00:55:17 2026 +0200

    UI: Load Monaco codicon glyph styles via direct CSS import (#69419)
    
    monaco-editor 0.53 removed the `codiconStyles` side-effect module that the
    local ESM Monaco setup imported to register the codicon glyph font (the
    folding arrows and find-widget icons). Import the two stylesheets that 
module
    pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` —
    directly instead, mirroring the existing dynamic-CSS-import pattern already
    used for Katex.
    
    Both files ship in the currently pinned 0.52.2 and in newer releases, so 
this
    is behaviour-neutral today and lets the editor keep rendering its glyphs 
once
    monaco-editor is bumped past 0.52, unblocking the pending dependency update.
---
 .../src/airflow/ui/src/components/MonacoEditor/configureMonaco.ts   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/airflow-core/src/airflow/ui/src/components/MonacoEditor/configureMonaco.ts 
b/airflow-core/src/airflow/ui/src/components/MonacoEditor/configureMonaco.ts
index 737de9e020c..97b6ae6be20 100644
--- a/airflow-core/src/airflow/ui/src/components/MonacoEditor/configureMonaco.ts
+++ b/airflow-core/src/airflow/ui/src/components/MonacoEditor/configureMonaco.ts
@@ -34,7 +34,11 @@ const loadMonacoModules = async () => {
     import("monaco-editor/esm/vs/editor/editor.api"),
     import("monaco-editor/esm/vs/editor/contrib/folding/browser/folding"),
     import("monaco-editor/esm/vs/editor/contrib/find/browser/findController"),
-    import("monaco-editor/esm/vs/base/browser/ui/codicons/codiconStyles"),
+    // monaco-editor 0.53 removed the `codiconStyles` side-effect module; 
import the two codicon
+    // stylesheets it used to pull in directly so folding/find glyphs still 
render. Both files
+    // ship in 0.52 and 0.55, so this resolves against the current pin and any 
newer bump.
+    
import("monaco-editor/esm/vs/base/browser/ui/codicons/codicon/codicon.css"),
+    
import("monaco-editor/esm/vs/base/browser/ui/codicons/codicon/codicon-modifiers.css"),
   ]).then(([api]) => api);
 
   // Resolve the bundled worker URLs (`?worker&url` runs the worker through 
Vite's worker

Reply via email to