potiuk opened a new pull request, #69465:
URL: https://github.com/apache/airflow/pull/69465
Manual, release-process workflows restrict who may trigger them by
duplicating a hardcoded release-manager allowlist as an `if:
contains(fromJSON('[...]'), github.event.sender.login)` on the first job. The
list drifts across files, only gates the *actor* (not the secrets consumed),
and is easy to get wrong.
This replaces those allowlists in the **prod image release**
(`release_dockerhub_image.yml`) and **docs-to-S3 publish**
(`publish-docs-to-s3.yml`) workflows with a dedicated, RM-only `release`
**deployment environment** referenced by the entry job. Access control and
secret scoping then live in one place.
**Draft** because the `release` environment must first be created by ASF
INFRA with release managers as required reviewers. Until it exists with
protection rules, a job referencing it runs ungated — so this must not merge
before INFRA sets it up (the issue's open question is exactly what `.asf.yaml`
can express here).
Deliberately **not** in this PR (tracked in #69460 / the follow-up):
- `update-constraints-on-push.yml` — its manual dispatch is added in #69457;
convert once that merges.
- `registry-backfill.yml` / `registry-build.yml` — their entry job is a
reusable-workflow call, which can't carry `environment:`; needs a small
gating-job restructure.
- `release_single_dockerhub_image.yml` DOCKERHUB secret scoping.
- CI-time secret workflows + re-enabling zizmor `secrets-outside-env`.
Part of #69460.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.8)
Generated-by: Claude Code (Opus 4.8) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
