jason810496 commented on code in PR #69299:
URL: https://github.com/apache/airflow/pull/69299#discussion_r3533748966
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -559,6 +561,19 @@ def get_task_log(self, ti: TaskInstance, try_number: int)
-> tuple[list[str], li
"""
return [], []
+ def get_streaming_task_log(self, ti: TaskInstance, try_number: int) ->
StreamingLogResponse:
+ """
+ Return a streaming response for task logs.
+
+ Executors that implement this method must also set the
``supports_streaming_logs`` class
+ attribute to ``True``.
Review Comment:
Nice catch and it's a good idea. I addressed in
https://github.com/apache/airflow/pull/69299/changes/11d346d44eafcdc1e29013aba60c798dd9cf0539.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
