dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql
odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r363024332
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
ok after reviewing [pyodbc
docs](https://github.com/mkleehammer/pyodbc/wiki/Module) i decided to add
support for connect_kwargs to both hook init and conn str. i am not nesting
the odbc properties, just making it optional to supply connect kwargs alongside
them.
e.g. like so:
```
{
"Driver": "ODBC Driver 17 for SQL Server",
"ApplicationIntent": "ReadOnly",
"TrustedConnection": "Yes",
"connect_kwargs": {
"autocommit": "false",
"ansi": "true",
}
}
```
i will probably update some of the documentation over the weekend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
