stephsi commented on code in PR #69271:
URL: https://github.com/apache/airflow/pull/69271#discussion_r3545185486
##########
providers/smtp/tests/unit/smtp/notifications/test_smtp.py:
##########
@@ -211,6 +211,70 @@ def test_notifier_with_nondefault_connection_extra(
**DEFAULT_EMAIL_PARAMS,
)
+ @mock.patch("airflow.providers.smtp.notifications.smtp.SmtpHook")
+ def test_notifier_from_email_falls_back_to_config(self,
mock_smtphook_hook, create_dag_without_db):
+ """When from_email is unset and the connection defines none, `[email]
from_email` config is used."""
Review Comment:
```suggestion
"""When config [email] from_email is set and the SMTP connection
extra `from_email` is NOT set, `[email] from_email` config is used."""
```
I assume `unset` was a typing mistake as this is the test case where the
config is set and the connection extra field is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
