bramhanandlingala commented on PR #69271: URL: https://github.com/apache/airflow/pull/69271#issuecomment-4927372144
Hi @stephsi Good catch, thanks — that was indeed a typo, "unset" should've said the connection extra is not set. Fixed in the latest commit using your suggested wording exactly. I've also added a matching docstring to test_notifier_with_nondefault_connection_extra so all four tests (connection-only, config-only, connection-over-config, neither-set-default) are now consistent in style, per your other comment. Happy to take any further wording suggestions if you have them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
