mik-laj commented on a change in pull request #7050: [AIRFLOW-XXXX] Update 
types in docstrings
URL: https://github.com/apache/airflow/pull/7050#discussion_r363059888
 
 

 ##########
 File path: airflow/sensors/external_task_sensor.py
 ##########
 @@ -47,11 +47,11 @@ class ExternalTaskSensor(BaseSensorOperator):
         For yesterday, use [positive!] datetime.timedelta(days=1). Either
         execution_delta or execution_date_fn can be passed to
         ExternalTaskSensor, but not both.
-    :type execution_delta: datetime.timedelta
+    :type execution_delta: datetime.timedelta or None
     :param execution_date_fn: function that receives the current execution date
         and returns the desired execution dates to query. Either 
execution_delta
         or execution_date_fn can be passed to ExternalTaskSensor, but not both.
-    :type execution_date_fn: callable
+    :type execution_date_fn: function or None
 
 Review comment:
   ```suggestion
       :type execution_date_fn: OptionalCallable]
   ```
   We prefer PEP syntax. It is also correct and more standardized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to