mik-laj commented on a change in pull request #7050: [AIRFLOW-XXXX] Update 
types in docstrings
URL: https://github.com/apache/airflow/pull/7050#discussion_r363099793
 
 

 ##########
 File path: airflow/sensors/base_sensor_operator.py
 ##########
 @@ -42,9 +42,9 @@ class BaseSensorOperator(BaseOperator, SkipMixin):
     :type soft_fail: bool
     :param poke_interval: Time in seconds that the job should wait in
         between each tries
-    :type poke_interval: int
+    :type poke_interval: float
 
 Review comment:
   For me it should be a float here. We use it in two places. In timedelta 
(seconds) and in sleep. The second case is obvious, but the second is not, so I 
looked at code. 
   ![Screenshot 2020-01-05 at 16 22 
58](https://user-images.githubusercontent.com/12058428/71782186-ac18c500-2fd7-11ea-9b8a-932ceb8f5b39.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to