dabla commented on code in PR #69564: URL: https://github.com/apache/airflow/pull/69564#discussion_r3564299296
########## providers/microsoft/azure/src/airflow/providers/microsoft/azure/fs/msgraph.py: ########## @@ -27,6 +27,55 @@ schemes = ["msgraph", "sharepoint", "onedrive", "msgd"] +#: Default scope requested when fetching a certificate-based access token. +#: Matches ``KiotaRequestAdapterHook.DEFAULT_SCOPE``. +DEFAULT_SCOPE = "https://graph.microsoft.com/.default"; + + +def _get_certificate_token( Review Comment: Sorry, this was a bad idea of mine, cause I see you have to pass the class as well, as msgraph hook uses the async aio version of it while the fs one uses the sync one, so this refactor doesn't make much sense. I would revert that change as it doesn't offer much honestly and I don't like the fact that we need to pass the class. So I would revert that last change, if static checks are green, we can merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
