Vamsi-klu commented on PR #69741:
URL: https://github.com/apache/airflow/pull/69741#issuecomment-4965893473
@bbovenzi thanks for asking for screenshots. I captured this from the latest
PR branch/commit.
### Screenshot proof
1. **Snowflake provider fields loaded from raw Extra JSON**
- Shows: the real Airflow Connections edit form for
`pr_69741_snowflake_raw_extra_714`, with `Account` populated from raw extra and
other provider fields still blank.
- Addresses: request for visual proof of the new connection form behavior.
- Screenshot: 
2. **Raw Extra JSON preserved before provider edits**
- Shows: raw JSON contains only `account` and `unknown`; no untouched
provider default such as `insecure_mode` was injected.
- Addresses: preservation of raw/provider-unknown extras on reopen.
- Screenshot: 
3. **Provider edit merges into raw Extra JSON**
- Shows: after typing `test_warehouse` in the provider `Warehouse` field,
raw JSON keeps `unknown`, adds `warehouse`, and still omits `insecure_mode`.
- Addresses: the changed behavior for provider-field edits without losing
raw extras or adding untouched defaults.
- Screenshot: 
### Validation
- Branch/commit: `fix-57984-snowflake-extra` /
`5247ca8b39d848b5ccd1f679b26b0ef0ded6ee5a`
- Browser/viewport: `Chromium, 1440x1100`
- Manual flow: `Connections -> edit pr_69741_snowflake_raw_extra_714 ->
Extra Fields / Extra Fields JSON`
- Local check: `pnpm test ConnectionForm.test.tsx useParamStore.test.ts`
passed (`2` files, `5` tests)
- CI: current PR checks returned no failing checks; relevant Airflow React
UI and browser e2e checks are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
