PreethamSanji commented on code in PR #69703:
URL: https://github.com/apache/airflow/pull/69703#discussion_r3585115224
##########
chart/templates/_helpers.yaml:
##########
@@ -304,12 +304,23 @@ If release name contains chart name it will be used as a
full name.
value: ":{{ .Values.dags.gitSync.httpPort }}"
- name: GITSYNC_HTTP_BIND
value: ":{{ .Values.dags.gitSync.httpPort }}"
+ {{- if .Values.dags.gitSync.metrics.enabled }}
+ - name: GIT_SYNC_HTTP_METRICS
+ value: "true"
+ - name: GITSYNC_HTTP_METRICS
+ value: "true"
Review Comment:
Yes, v3 has `--http-metrics` / `GIT_SYNC_HTTP_METRICS`, default `true` in
the release-3.x docs, serving `/metrics` on the `--http-bind` endpoint.
In v4 the default changed to `false`, which is why the explicit var is
needed there. v4 also reads both spellings, so I'm happy to drop the
v3-spelling var and keep only `GITSYNC_HTTP_METRICS` if you'd prefer.
https://github.com/kubernetes/git-sync/blob/release-3.x/README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
