guan404ming commented on code in PR #69302:
URL: https://github.com/apache/airflow/pull/69302#discussion_r3595950192
##########
ts-sdk/src/coordinator/log-channel.ts:
##########
@@ -47,31 +47,45 @@ export interface LogRecord {
const DEFAULT_LOGGER_NAME = "ts-sdk";
+interface LogChannelState {
+ sock: Socket;
+ connected: boolean;
+ closed: boolean;
+}
+
Review Comment:
Thanks for the suggestion. One question though `startCoordinator()` connects
the log socket first, and a `LogChannel` only exists after connect(), so I
think that there may be no record can be emitted pre-connect. The only
pre-connect output is genuine failures, where stderr at ERROR seems
semantically right. Feel free to correct me if I miss any cases, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
