jason810496 commented on code in PR #69302:
URL: https://github.com/apache/airflow/pull/69302#discussion_r3608252730
##########
ts-sdk/src/coordinator/log-channel.ts:
##########
@@ -47,31 +47,45 @@ export interface LogRecord {
const DEFAULT_LOGGER_NAME = "ts-sdk";
+interface LogChannelState {
+ sock: Socket;
+ connected: boolean;
+ closed: boolean;
+}
+
Review Comment:
Sorry for the late reply:
The purpose of the buffer is different. No matter the final task state is
success or fail will need to handle the following scenario. (Both Java and Go
SDK handle this.)
Here's the lifecycle of the Lang-SDK subprocess.
1. TS subprocess started (by the `popen` on coordinator side)
2. TS execution time logger can still logs somethings at this moment! (e.g.
trying to connect to coordinator `--comms=127:<port> ...` ..
3. TS subprocess really connected to the coordinator.
4. All the logs from TS logger will forward to `--log` socket after
connected.
The buffer I mentioned handle the stage 2 where the TS logger can still log
before connected to the coordinator log socket. We should "buffer" the logs at
stage 2 and pass though to the log socket once connected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
