takayoshi-makabe commented on code in PR #69739:
URL: https://github.com/apache/airflow/pull/69739#discussion_r3607793790
##########
providers/dbt/cloud/src/airflow/providers/dbt/cloud/hooks/dbt.py:
##########
@@ -138,6 +138,32 @@ class DbtCloudResourceLookupError(AirflowException):
"""Exception raised when a dbt Cloud resource cannot be uniquely
identified."""
+class DbtCloudTriggerEventException(AirflowException):
+ """Raised when a deferred task resumes with a missing or malformed trigger
event."""
+
+
+#: Statuses the provider's trigger emits in its terminal event.
+TRIGGER_EVENT_STATUSES = frozenset({"success", "cancelled", "error",
"timeout"})
+
+
+def validate_execute_complete_event(event: dict[str, Any] | None = None) ->
dict[str, Any]:
+ """
+ Validate the event a deferred task resumes with, returning it if
well-formed.
+
+ The event crosses the triggerer/worker boundary through the metadata DB,
so a
+ resuming task can receive ``None`` (e.g. a lost payload) or a status its
handlers
+ do not recognize (triggerer/worker version skew, a custom trigger). Both
must fail
+ loudly rather than silently falling through to the success path.
+ """
+ if event is None:
+ raise DbtCloudTriggerEventException("Trigger error: event is None")
+ if event.get("status") not in TRIGGER_EVENT_STATUSES:
+ raise DbtCloudTriggerEventException(
+ f"Unexpected trigger event status {event.get('status')!r}:
{event!r}"
+ )
+ return event
Review Comment:
@nailo2c
Good catch, but I kept the scope aligned with the sibling fixes in anthropic
(#69379) and amazon, which also only validate None/status and not individual
payload keys. A missing run_id/message would still fail loudly with a KeyError
rather than silently succeeding, which is the failure mode this PR is actually
guarding against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
