bbovenzi commented on code in PR #70142:
URL: https://github.com/apache/airflow/pull/70142#discussion_r3616928006
##########
airflow-core/newsfragments/70142.improvement.rst:
##########
Review Comment:
Let's remove the newsfragment
##########
airflow-core/src/airflow/ui/src/pages/Task/Overview/Overview.tsx:
##########
@@ -103,8 +103,8 @@ export const Overview = () => {
startDate={startDate}
/>
</HStack>
- <SimpleGrid columns={3} gap={5} my={5}>
- <Box borderRadius={4} borderStyle="solid" borderWidth={1} p={2}
width="350px">
+ <SimpleGrid columns={1} gap={5} my={5}>
+ <Box borderRadius={4} borderStyle="solid" borderWidth={1}
maxWidth="900px" p={2}>
Review Comment:
I'd also like to see a screenshot of how this is different and how the min
and max sizes work for both overview pages.
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/components.json:
##########
@@ -65,6 +65,7 @@
"lastDagRun_other": "Last {{count}} Dag Runs",
"lastTaskInstance_one": "Last Task Instance",
"lastTaskInstance_other": "Last {{count}} Task Instances",
+ "medianTotalDuration": "Median total: {{duration}}",
Review Comment:
I feel like "Median total" is a bit confusing. "Total:" is fine in my opinion
##########
airflow-core/src/airflow/ui/src/pages/Task/Overview/Overview.tsx:
##########
@@ -103,8 +103,8 @@ export const Overview = () => {
startDate={startDate}
/>
</HStack>
- <SimpleGrid columns={3} gap={5} my={5}>
- <Box borderRadius={4} borderStyle="solid" borderWidth={1} p={2}
width="350px">
+ <SimpleGrid columns={1} gap={5} my={5}>
+ <Box borderRadius={4} borderStyle="solid" borderWidth={1}
maxWidth="900px" p={2}>
Review Comment:
Why is this different from the same Box in the Dag Overview?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
