eddiesr93 commented on code in PR #70142:
URL: https://github.com/apache/airflow/pull/70142#discussion_r3617036199
##########
airflow-core/src/airflow/ui/src/pages/Task/Overview/Overview.tsx:
##########
@@ -103,8 +103,8 @@ export const Overview = () => {
startDate={startDate}
/>
</HStack>
- <SimpleGrid columns={3} gap={5} my={5}>
- <Box borderRadius={4} borderStyle="solid" borderWidth={1} p={2}
width="350px">
+ <SimpleGrid columns={1} gap={5} my={5}>
+ <Box borderRadius={4} borderStyle="solid" borderWidth={1}
maxWidth="900px" p={2}>
Review Comment:
No good reason — that was an inconsistency on my side. The Task overview was
left in its single-column `SimpleGrid` with only a `maxWidth`, while the Dag
overview flexed.
Both pages now use the identical Box:
```tsx
<Box
borderRadius={4}
borderStyle="solid"
borderWidth={1}
flex="1 1 520px"
maxWidth="900px"
minWidth="320px"
p={2}
>
```
The `SimpleGrid` is gone (it only ever wrapped one child) and the Task
overview uses the same wrapping `HStack`. Adopting the cap on the Dag overview
also fixes something the flex version had wrong on its own: without `maxWidth`
the chart kept growing on an ultrawide monitor.
---
Drafted-by: Claude Code (Opus 4.8) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]