gopidesupavan commented on code in PR #70144: URL: https://github.com/apache/airflow/pull/70144#discussion_r3617896880
########## providers/common/ai/src/airflow/providers/common/ai/toolsets/__init__.py: ########## @@ -20,7 +20,13 @@ from airflow.providers.common.ai.toolsets.hook import HookToolset -__all__ = ["AWSToolset", "HookToolset", "MCPToolset", "SQLToolset", "airflow_toolset_to_langchain_tools"] +__all__ = [ + "GoogleCloudToolset", Review Comment: `HookToolset` is still useful when the workflow maps to existing hook methods. The gap here is that it only exposes Python methods that a hook already wraps, while this toolset exposes allowed Google API client methods directly. For example, an incident triage agent might need to check recent BigQuery jobs, Dataflow jobs, and GCS object arrival. With `GoogleCloudToolset`, the Dag author can allow-list the exact API methods, such as `bigquery/v2:jobs.list`, `bigquery/v2:jobs.get`, `dataflow/v1b3:projects.locations.jobs.list`, and `storage/v1:objects.list`. Doing the same with `HookToolset` depends on each service hook having the right method and returning data in a useful shape for the agent. Some APIs also have no dedicated hook coverage. For example, Cloud Monitoring time series reads can be exposed as `monitoring/v3:projects.timeSeries.list`, while the existing Stackdriver hook mainly wraps alert policy and notification channel operations. So this is not replacing `HookToolset`; it is for cases where the agent should call selected Google REST API methods directly, instead of being limited to the Python methods currently wrapped by Airflow hooks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
