gopidesupavan commented on code in PR #70144:
URL: https://github.com/apache/airflow/pull/70144#discussion_r3618127385


##########
providers/common/ai/src/airflow/providers/common/ai/toolsets/__init__.py:
##########
@@ -20,7 +20,13 @@
 
 from airflow.providers.common.ai.toolsets.hook import HookToolset
 
-__all__ = ["AWSToolset", "HookToolset", "MCPToolset", "SQLToolset", 
"airflow_toolset_to_langchain_tools"]
+__all__ = [
+    "GoogleCloudToolset",

Review Comment:
   
   One example I tested was this prompt:
   
   ```
   Pipeline is slow today in project `playground-s-11-af79665a`. Check active 
Cloud Monitoring alert policies, list recent BigQuery pipeline rows, and 
confirm raw files arrived in `gs://gcp-toolset-demo-af79665a/raw/`. Then 
compare Cloud Monitoring metrics for BigQuery query count and GCS request count 
for today versus yesterday.
   ```
   
   With `HookToolset`, the agent handled the parts backed by existing hook 
methods: alert policies, BigQuery rows, and GCS object listing. But it could 
not answer the Monitoring time-series part because that metric-read operation 
is not exposed by the hook methods available to it.
   
   With `GoogleCloudToolset`, the agent completed the full request by calling 
the relevant Google REST API methods directly, including 
`monitoring/v3:projects.timeSeries.list`.
   
   This is just one example; in other multi-service troubleshooting questions 
the missing piece may be a different Google API method. ideally here it is not 
to replace `HookToolset`, but to support cases where we want to expose selected 
Google API methods without needing a dedicated Airflow hook wrapper for each 
one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to