Phinhas214 commented on code in PR #70151:
URL: https://github.com/apache/airflow/pull/70151#discussion_r3618658154


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py:
##########
@@ -52,6 +58,14 @@
 def list_backfills_ui(
     limit: QueryLimit,
     offset: QueryOffset,
+    start_date_range: Annotated[RangeFilter, 
Depends(datetime_range_filter_factory("from_date", Backfill))],

Review Comment:
   - `start_date`/`end_date` are exposed as public filter names, but `Backfill` 
has no columns
     with those literal names. The underlying columns are 
`from_date`/`to_date`. 
   - Used
     `datetime_range_filter_factory`'s `attribute_name` argument to map the 
public-facing name to
     the real column, so the API surface matches what `DagRun` already exposes 
without renaming
     Backfill's columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to