Phinhas214 commented on code in PR #70151:
URL: https://github.com/apache/airflow/pull/70151#discussion_r3618667046
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py:
##########
@@ -52,6 +58,14 @@
def list_backfills_ui(
limit: QueryLimit,
offset: QueryOffset,
+ start_date_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("from_date", Backfill))],
+ end_date_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("to_date", Backfill))],
+ created_at: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("created_at", Backfill))],
+ completed_at: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("completed_at", Backfill))],
+ max_active_runs: Annotated[RangeFilter,
Depends(float_range_filter_factory("max_active_runs", Backfill))],
Review Comment:
`max_active_runs` is implemented as a `RangeFilter` (via
`float_range_filter_factory`) rather
than an exact-match `FilterParam`, since the issue frames it as diagnosing
throttling
("more/fewer than N active runs"), which a range serves better than exact
equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
