Sanjays2402 commented on code in PR #70152:
URL: https://github.com/apache/airflow/pull/70152#discussion_r3619424202
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/datasync.py:
##########
@@ -181,7 +192,7 @@ def __init__(
if self.source_location_uri and self.destination_location_uri:
valid = True
if not valid:
- raise AirflowException(
+ raise ValueError(
Review Comment:
switching this from AirflowException to ValueError is a behavior change for
anyone catching AirflowException around operator construction, since ValueError
isn't in that hierarchy. the raises in execute() all stay AirflowException
subclasses, so this one's now the odd one out. intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
