henry3260 commented on code in PR #69578:
URL: https://github.com/apache/airflow/pull/69578#discussion_r3623364250
##########
shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml:
##########
@@ -39,14 +39,6 @@ metrics:
legacy_name: "-"
name_variables: ["job_name"]
- - name: "local_task_job.task_exit"
Review Comment:
I think we should delete this as well
https://github.com/apache/airflow/blob/723b06b38a95608bb082494b973d48d25e7a6808/shared/observability/src/airflow_shared/observability/metrics/validators.py#L59
##########
scripts/ci/prek/check_metrics_synced_with_the_registry.py:
##########
@@ -67,6 +68,16 @@
AIRFLOW_ROOT_PATH /
"shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml"
)
+EXCLUDED_TESTS_PATTERN = re.compile(r"(^|/)tests/")
+
+# Registry metrics emitted through a variable that the AST scan cannot resolve
back to a
+# string literal, e.g. names built by BaseExecutor._get_metric_name.
+INDIRECTLY_EMITTED_METRICS = {
Review Comment:
Could we also check this hardcoded list against the registry? If any of
these metrics are deleted or renamed, we’d otherwise have to remember to update
this list manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
