FrankYang0529 commented on code in PR #69578:
URL: https://github.com/apache/airflow/pull/69578#discussion_r3634934205
##########
scripts/ci/prek/check_metrics_synced_with_the_registry.py:
##########
@@ -67,6 +68,16 @@
AIRFLOW_ROOT_PATH /
"shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml"
)
+EXCLUDED_TESTS_PATTERN = re.compile(r"(^|/)tests/")
+
+# Registry metrics emitted through a variable that the AST scan cannot resolve
back to a
+# string literal, e.g. names built by BaseExecutor._get_metric_name.
+INDIRECTLY_EMITTED_METRICS = {
Review Comment:
Good catch! Add `find_stale_indirectly_emitted_metrics` for this case. If
any metric in `INDIRECTLY_EMITTED_METRICS` is stale, we can catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
