dabla opened a new pull request, #70230:
URL: https://github.com/apache/airflow/pull/70230
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Currently, selective checks skip `check-provider-yaml-valid` unless a
`provider.yaml`, `pyproject.toml`, or provider Python file changed.
This means that when only `scripts/ci/prek/check_provider_yaml_files.py`
or `providers/.pre-commit-config.yaml` is modified, the check is silently
skipped — so a bug introduced in the check script itself goes undetected
in CI.
This was the root cause of the `FileNotFoundError` for
`providers/apache/provider.yaml` reported after #70007 merged: the
`_resolve_provider_yaml_files()` function mapped any provider Python file
to `<pkg>/provider.yaml` without guarding against non-provider-package
paths like `apache/`, but `check-provider-yaml-valid` never ran in that
PR's CI to catch it.
## Changes
- Add `providers/.pre-commit-config.yaml` to
`ALL_PROVIDERS_DISTRIBUTION_CONFIG_FILES` so changes to the providers
prek configuration are treated like `provider.yaml` changes.
- Add `PREK_FILES` as an additional condition: when any prek script
changes, `check-provider-yaml-valid` is no longer skipped.
- Add a test covering both trigger paths.
- Update `dev/breeze/doc/ci/04_selective_checks.md` to document the new
rule.
## Related
- Bug introduced by: [#70007](https://github.com/apache/airflow/pull/70007)
- Static check fix: [#70224](https://github.com/apache/airflow/pull/70224)
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ x ] Yes (please specify the tool below)
Claude Sonnet 4.6 (GitHub Copilot CLI)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
