amoghrajesh commented on code in PR #70230:
URL: https://github.com/apache/airflow/pull/70230#discussion_r3629821534
##########
dev/breeze/doc/ci/04_selective_checks.md:
##########
@@ -508,8 +508,9 @@ when some files are not changed. Those are the rules
implemented:
skipped (it regenerates and diffs the generated ts-sdk file; a change to
the supervisor
wire schema alone deliberately does not trigger it - regenerating the
ts-sdk types is
the ts-sdk follow-up PR's job, not the schema author's)
- * if no `All Providers Python files` and no `All Providers Yaml files` are
changed -
- `check-provider-yaml-valid` check is skipped
+ * if no `All Providers Python files` and no `All Providers Yaml files` are
changed and no
+ `Prek files` changed - `check-provider-yaml-valid` check is skipped (the
prek condition
+ ensures the check still runs when the provider yaml check script itself
changes)
Review Comment:
Not entirely by you, but this sentence is really hard to read.
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -2028,6 +2028,30 @@ def test_full_test_needed_when_scripts_changes(files:
tuple[str, ...], expected_
assert_outputs_are_printed(expected_outputs, str(stderr))
[email protected](
+ ("files",),
+ [
+ pytest.param(
+ ("scripts/ci/prek/check_provider_yaml_files.py",),
+ id="provider yaml check script changed",
+ ),
+ pytest.param(
+ ("providers/.pre-commit-config.yaml",),
+ id="providers prek config changed",
Review Comment:
Can you have a test case / cases with a combination too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
