vio-ao commented on PR #69442: URL: https://github.com/apache/airflow/pull/69442#issuecomment-5054729802
Thanks for the review! You're right — `self.databricks_run_id` is the shared parent workflow run ID for workflow members, so cancelling it would stop sibling tasks. Fixed in the latest commit. `on_kill()` now mirrors `monitor_databricks_job`: for workflow members it calls `_get_current_databricks_task()["run_id"]` to get the child task's own run ID, while standalone operators continue to cancel via `self.databricks_run_id` directly. Also added the regression test you suggested: parent run_id=1, `_get_current_databricks_task` returns child run_id=999, asserts `cancel_run(999)`. The branch has also been squashed to a single commit to fix the `fix:` subject check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
