Vamsi-klu commented on PR #69442:
URL: https://github.com/apache/airflow/pull/69442#issuecomment-5055103660
Thanks for the quick turnaround. I re-checked HEAD (`feb6783`) end-to-end.
### Confirmed fixed
- Workflow members cancel via `_get_current_databricks_task()["run_id"]`
only (not the shared parent run id)
- On child-run resolve failure: log + return (no parent fallback)
- Unit coverage:
- standalone cancel
- no-op when `databricks_run_id` is `None`
- workflow member child cancel (`parent=1` -> `cancel_run(999)`)
- workflow member exception path (`cancel_run` not called)
- Single commit; subject no longer uses a rejected `fix:` prefix
### Residual before this is ready
Both touched files drop the first two lines of the standard ASF license
header:
```text
#
# Licensed to the Apache Software Foundation (ASF) under one
```
Please restore the full header in:
1.
`providers/databricks/src/airflow/providers/databricks/operators/databricks.py`
2. `providers/databricks/tests/unit/databricks/operators/test_databricks.py`
### Testing bar
No live Databricks credentials/UI testing needed for merge. This matches how
`DatabricksSubmitRunOperator` / `DatabricksRunNowOperator` `on_kill` is
validated: mock `cancel_run` and assert the correct run id.
A rebase onto current `main` will still be needed before merge (branch is
quite behind). That can land together with the header fix.
Logic otherwise looks good from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
