shahar1 commented on code in PR #70488:
URL: https://github.com/apache/airflow/pull/70488#discussion_r3655775955
##########
providers/google/src/airflow/providers/google/cloud/operators/gcs.py:
##########
@@ -311,25 +311,20 @@ def __init__(
impersonation_chain: str | Sequence[str] | None = None,
**kwargs,
) -> None:
+ super().__init__(**kwargs)
self.bucket_name = bucket_name
self.objects = objects
self.prefix = prefix
self.ignore_error = ignore_error
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
- if objects is None and prefix is None:
- err_message = "(Task {task_id}) Either objects or prefix should be
set. Both are None.".format(
- **kwargs
- )
- raise ValueError(err_message)
- if objects is not None and prefix is not None:
- err_message = "(Task {task_id}) Objects or prefix should be set.
Both provided.".format(**kwargs)
- raise ValueError(err_message)
-
- super().__init__(**kwargs)
-
Review Comment:
Please restore the changes here, as it will be flagged as false-positive
(see #https://github.com/apache/airflow/pull/70505 for more details)
##########
scripts/ci/prek/validate_operators_init_exemptions.txt:
##########
@@ -25,8 +25,6 @@
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_tran
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py::DataprocCreateClusterOperator
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py::DataprocSubmitJobOperator
providers/google/src/airflow/providers/google/cloud/operators/functions.py::CloudFunctionDeployFunctionOperator
-providers/google/src/airflow/providers/google/cloud/operators/gcs.py::GCSDeleteObjectsOperator
Review Comment:
Please restore this lien
##########
providers/google/src/airflow/providers/google/cloud/operators/gcs.py:
##########
@@ -311,25 +311,20 @@ def __init__(
impersonation_chain: str | Sequence[str] | None = None,
**kwargs,
) -> None:
+ super().__init__(**kwargs)
self.bucket_name = bucket_name
self.objects = objects
self.prefix = prefix
self.ignore_error = ignore_error
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
- if objects is None and prefix is None:
- err_message = "(Task {task_id}) Either objects or prefix should be
set. Both are None.".format(
- **kwargs
- )
- raise ValueError(err_message)
- if objects is not None and prefix is not None:
- err_message = "(Task {task_id}) Objects or prefix should be set.
Both provided.".format(**kwargs)
- raise ValueError(err_message)
-
- super().__init__(**kwargs)
-
def execute(self, context: Context) -> None:
+ if self.objects is None and self.prefix is None:
+ raise ValueError(f"(Task {self.task_id}) Either objects or prefix
should be set. Both are None.")
+ if self.objects is not None and self.prefix is not None:
+ raise ValueError(f"(Task {self.task_id}) Objects or prefix should
be set. Both provided.")
+
Review Comment:
Please revert these changes
##########
scripts/ci/prek/validate_operators_init_exemptions.txt:
##########
@@ -25,8 +25,6 @@
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_tran
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py::DataprocCreateClusterOperator
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py::DataprocSubmitJobOperator
providers/google/src/airflow/providers/google/cloud/operators/functions.py::CloudFunctionDeployFunctionOperator
-providers/google/src/airflow/providers/google/cloud/operators/gcs.py::GCSDeleteObjectsOperator
Review Comment:
Please restore this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
