potiuk opened a new pull request, #70642:
URL: https://github.com/apache/airflow/pull/70642

   `breeze build-docs` ignored the requested Python version — it hardcoded 
breeze's
   default (3.10) both for the CI image it looks for and for the shell it runs 
the
   Sphinx build in, because the command never had a `--python` option.
   
   That is what happened in [Publish Docs to S3 run 
30392033558](https://github.com/apache/airflow/actions/runs/30392033558):
   the workflow built, stashed, restored and loaded 
`ghcr.io/apache/airflow/main/ci/python3.12`,
   and the docs step then went looking for a **3.10** image, did not find one, 
and
   started a full from-scratch rebuild 
(`--cache-from=…/ci/python3.10:cache-linux-amd64`,
   `AIRFLOW_PYTHON_VERSION=3.10.20`) — discarding the image the run had just 
prepared
   and documenting against a different interpreter than the workflow intended.
   
   `build-docs` now takes `--python` (env `PYTHON_MAJOR_MINOR_VERSION`, same as 
every
   other image-using breeze command) and passes it to both `BuildCiParams` and
   `ShellParams`. The `publish-docs-to-s3` job also carried a stale hardcoded
   `PYTHON_MAJOR_MINOR_VERSION: "3.10"`; it now follows 
`default-python-version` like
   every other job in that workflow.
   
   The docs job in `ci-image-checks.yml` had the same latent bug, but it passes
   `default-python-version` (3.10), so nothing changes there — it is now 
correct by
   construction rather than by coincidence.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to