RoyLee1224 commented on code in PR #70120:
URL: https://github.com/apache/airflow/pull/70120#discussion_r3680688314
##########
dev/skill-evals/eval.py:
##########
@@ -102,11 +109,17 @@ def find_sdk_modules() -> Path:
if pf_pkg.parent == pf_pkg:
break
pf_pkg = pf_pkg.parent
+ package_parts = sdk_package.split("/")
for candidate in (pf_pkg / "node_modules", pf_pkg.parent):
- if (candidate / "@anthropic-ai" / "claude-agent-sdk").is_dir():
+ package_json = candidate.joinpath(*package_parts,
"package.json")
+ try:
+ installed_version =
json.loads(package_json.read_text())["version"]
+ except (OSError, KeyError, ValueError):
+ continue
+ if installed_version == expected_version:
Review Comment:
Yes, but prek installs the pinned version automatically, so contributors do
not select or install it themselves.
I removed the version comparison. The code now selects the SDK installed by
the hook instead of promptfoo's bundled copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
