RoyLee1224 commented on code in PR #70120:
URL: https://github.com/apache/airflow/pull/70120#discussion_r3680804679


##########
.pre-commit-config.yaml:
##########
@@ -1019,7 +1019,10 @@ repos:
         entry: ./dev/skill-evals/eval.py
         language: node
         language_version: '22.22.0'
-        additional_dependencies: ['[email protected]', 
'@anthropic-ai/[email protected]']
+        additional_dependencies:
+          - '[email protected]'
+          - '@anthropic-ai/[email protected]'
+          - '@openai/[email protected]'

Review Comment:
   It is technically possible, but prek would still install the fallback before 
the hook runs, so it would not reduce the download. It would also make the eval 
depend on an unpinned system CLI.
   
   I prefer keeping the CLI managed by the separate manual prek hook for 
reproducible runs. Authentication still comes from the user's existing session.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to