bujjibabukatta commented on PR #70635: URL: https://github.com/apache/airflow/pull/70635#issuecomment-5127977930
Hey @ferruzzi, thanks for digging into this so carefully — went through all four: The re-deferral thing was a genuine bug, glad you caught it. Fixed it so we only skip the current triggerer's stream while DEFERRED, not the whole lookup — so logs from an earlier deferral don't disappear anymore. Added a test to lock that in. Renamed _get_trigger_stream_names to get_trigger_stream_names (dropped the underscore), and did the same for the new shared helper. Cleaned up the parametrize test too — it's just a plain test now, no more unused param. And on the quota thing — heads up that the re-deferral fix actually makes DescribeLogStreams get called a bit more often now, not less, since it runs during DEFERRED too. Not opposed to gating it down the line (caching, or keying off TaskInstanceHistory) if it ends up mattering in practice, just didn't want to over-engineer it without real numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
