This is an automated email from the ASF dual-hosted git repository. vatsrahul1001 pushed a commit to branch backport-68545-v3-3-test in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 56bc3d05ed24022bf1c67fe5b16a0e7b25a6d9ae Author: SameerMesiah97 <[email protected]> AuthorDate: Wed Jul 1 22:32:34 2026 +0100 Triggerer: strengthen triggerer metric test coverage (#68545) (cherry picked from commit 9ecca013c9a47eba6e09da7d3497e3125dc630d1) --- airflow-core/tests/unit/jobs/test_triggerer_job.py | 30 +++++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/airflow-core/tests/unit/jobs/test_triggerer_job.py b/airflow-core/tests/unit/jobs/test_triggerer_job.py index 91e62cf4113..c354f6cf17f 100644 --- a/airflow-core/tests/unit/jobs/test_triggerer_job.py +++ b/airflow-core/tests/unit/jobs/test_triggerer_job.py @@ -2965,7 +2965,12 @@ def test_handle_events_does_not_confirm_seq_when_persist_fails(jobless_superviso def test_handle_events_emits_team_name(jobless_supervisor, team_name, expected_tags): """triggers.succeeded carries the triggerer's team_name (omitted when the triggerer has none).""" jobless_supervisor.team_name = team_name - jobless_supervisor.events.append(TriggerEventEntry(1, TriggerEvent(True), 7)) + jobless_supervisor.events.extend( + [ + TriggerEventEntry(1, TriggerEvent(True), 7), + TriggerEventEntry(2, TriggerEvent(True), 8), + ] + ) with ( mock.patch.object(TriggerRunnerSupervisor, "on_trigger_event", autospec=True), @@ -2973,7 +2978,13 @@ def test_handle_events_emits_team_name(jobless_supervisor, team_name, expected_t ): jobless_supervisor.handle_events() - mock_incr.assert_called_once_with("triggers.succeeded", tags=expected_tags) + mock_incr.assert_has_calls( + [ + mock.call("triggers.succeeded", tags=expected_tags), + mock.call("triggers.succeeded", tags=expected_tags), + ] + ) + assert mock_incr.call_count == 2 @pytest.mark.parametrize( @@ -2986,7 +2997,12 @@ def test_handle_events_emits_team_name(jobless_supervisor, team_name, expected_t def test_handle_failed_triggers_emits_team_name(jobless_supervisor, team_name, expected_tags): """triggers.failed carries the triggerer's team_name (omitted when the triggerer has none).""" jobless_supervisor.team_name = team_name - jobless_supervisor.failed_triggers.append((1, None)) + jobless_supervisor.failed_triggers.extend( + [ + (1, Exception("failure one")), + (2, Exception("failure two")), + ] + ) with ( mock.patch.object(TriggerRunnerSupervisor, "on_trigger_failure", autospec=True), @@ -2994,7 +3010,13 @@ def test_handle_failed_triggers_emits_team_name(jobless_supervisor, team_name, e ): jobless_supervisor.handle_failed_triggers() - mock_incr.assert_called_once_with("triggers.failed", tags=expected_tags) + mock_incr.assert_has_calls( + [ + mock.call("triggers.failed", tags=expected_tags), + mock.call("triggers.failed", tags=expected_tags), + ] + ) + assert mock_incr.call_count == 2 @pytest.mark.parametrize(
