Aaryan123456679 commented on code in PR #70238:
URL: https://github.com/apache/airflow/pull/70238#discussion_r3697821650
##########
chart/tests/helm_tests/security/test_security_context.py:
##########
@@ -422,6 +422,120 @@ def test_main_pod_setting(self):
for doc in docs[1:]:
assert ctx_value ==
jmespath.search("spec.template.spec.securityContext", doc)
+ def test_disable_defaults_pod_and_container(self):
Review Comment:
Extended `test_disable_defaults_component_level_override_still_applied` into
a parametrized test covering all 13 components that `disableDefaults` touches —
`scheduler`, `apiServer`, `dagProcessor`, `triggerer`, `workers.celery`,
`flower`, `statsd`, `pgbouncer`, `redis`, `createUserJob`,
`migrateDatabaseJob`, `cleanup`, and `databaseCleanup` — matching every
template this PR's diff modifies. `databaseCleanup` wasn't covered by any other
test in the file either, so this closes that gap too.
Also split the volume-permissions init-container assertion into its own
`test_disable_defaults_workers_volume_permissions_init_container_still_added`
test, since it checks a different behavior (that `disableDefaults` doesn't
suppress init-container injection) from the component-override-priority
behavior the parametrized test now covers.
Full security test suite: 205 passed, 0 failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
