uranusjr commented on code in PR #71151: URL: https://github.com/apache/airflow/pull/71151#discussion_r3732761852
########## java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/conformance/Capabilities.kt: ########## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.airflow.sdk.conformance + +import kotlinx.serialization.SerialName +import kotlinx.serialization.Serializable +import kotlinx.serialization.encodeToString +import kotlinx.serialization.json.Json + +// This model exists only to emit the build-time manifest, so it is deliberately `internal`: it is +// not part of the SDK's published surface, and keeping it out means changing the manifest schema +// never becomes a source/binary compatibility concern for SDK users. Review Comment: Do we really need this? The module not referenced anywhere, and also not referencing anything. We can probably just write the JSON manually and use `validate_capabilities` to ensure it’s always good. Or maybe the format can be YAML instead to be more developer-friendly. (The reader side wouldn’t care much.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
