uranusjr commented on code in PR #71151:
URL: https://github.com/apache/airflow/pull/71151#discussion_r3732786512
##########
.pre-commit-config.yaml:
##########
@@ -280,6 +280,37 @@ repos:
(?x)
^java-sdk/gradle\.properties$|
^java-sdk/sdk/schema/schema\.json$
+ - id: check-java-sdk-capabilities-in-sync
+ name: Check java-sdk/generated/lang-sdk/capabilities.json matches the
Kotlin capability constant
+ entry: ./scripts/ci/prek/check_java_sdk_capabilities_in_sync.py
+ # system so the JDK/Gradle wrapper the dump task needs is taken from
the host toolchain,
+ # matching sync-java-sdk-supervisor-schema above. The Python entry
only imports the
+ # dependency-free lang_sdk_compat_matrix/common_prek_utils (no rich),
so system Python suffices.
+ language: system
Review Comment:
I’m not following; using `language: python` simply means a virtual
environment can be used, and Java in the host should still be available. I
don’t see an advantage using `system` here. (This would be moot if the
capabilities are declared directly instead of pulled from Kotlin.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
