bbovenzi commented on code in PR #71467:
URL: https://github.com/apache/airflow/pull/71467#discussion_r3761545583
##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -87,6 +88,13 @@ export const useFilterConfigs = () => {
label: translate("components:versionDetails.bundleVersion"),
type: FilterTypes.TEXT,
},
+ [SearchParamsKeys.COMPLETED_AT_RANGE]: {
+ endKey: SearchParamsKeys.COMPLETED_AT_LTE,
+ icon: <MdDateRange />,
+ label: translate("hitl:filters.completedAt"),
Review Comment:
We should move completedAt to a common filter key like the others.
##########
airflow-core/src/airflow/ui/src/constants/reprocessBehaviourParams.ts:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
export const reprocessBehaviors = [
- { label: "backfill.missingRuns", value: "none" },
- { label: "backfill.missingAndErroredRuns", value: "failed" },
- { label: "backfill.allRuns", value: "completed" },
+ { label: "Missing Runs", value: "none" },
+ { label: "Missing And Errored Runs", value: "failed" },
+ { label: "All Runs", value: "completed" },
Review Comment:
We need to keep the translation keys.
##########
airflow-core/src/airflow/ui/src/constants/searchParams.ts:
##########
@@ -71,6 +77,9 @@ export enum SearchParamsKeys {
LOGICAL_DATE_RANGE = "logical_date_range",
MAP_INDEX = "map_index",
MAPPED = "mapped",
+ MAX_ACTIVE_RUNS_GTE = "max_active_runs_gte",
+ MAX_ACTIVE_RUNS_LTE = "max_active_runs_lte",
+ MAX_ACTIVE_RUNS_RANGE = "max_active_runs_range",
Review Comment:
We aren't using this.
##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -237,6 +252,18 @@ export const useFilterConfigs = () => {
min: -1,
type: FilterTypes.NUMBER,
},
+ [SearchParamsKeys.MAX_ACTIVE_RUNS_GTE]: {
+ icon: <MdHourglassEmpty />,
Review Comment:
This isn't related to time. We should use a different icon for this and the
LTE
##########
airflow-core/src/airflow/ui/src/pages/Dag/Backfills/Backfills.tsx:
##########
Review Comment:
While we're at it. Let's remove this Heading. DataTable should handle it for
us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
