uranusjr commented on code in PR #70517:
URL: https://github.com/apache/airflow/pull/70517#discussion_r3762555684
##########
shared/observability/tests/observability/metrics/test_stats.py:
##########
@@ -71,6 +71,17 @@ def test_passes_ipv6_as_keyword(self, mock_stats_client):
statsd_logger.get_statsd_logger(stats_class=mock_stats_client,
ipv6=True)
assert mock_stats_client.call_args.kwargs["ipv6"] is True
+ def test_socket_path_constructs_stats_class_with_socket_path(self):
+ # In socket mode the builder constructs the given stats_class with
socket_path/prefix
+ # (host/port are omitted). The caller is responsible for passing a
socket-capable class.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
