sortega commented on code in PR #70517:
URL: https://github.com/apache/airflow/pull/70517#discussion_r3764966769
##########
shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py:
##########
@@ -171,12 +173,15 @@ def get_statsd_logger(
statsd_influxdb_enabled: bool = False,
) -> SafeStatsdLogger:
"""Return logger for StatsD."""
- statsd = stats_class(
- host=host,
- port=port,
- prefix=prefix,
- ipv6=ipv6,
- )
+ if socket_path is not None:
+ statsd = stats_class(socket_path=socket_path, prefix=prefix)
Review Comment:
Documented as such
##########
shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py:
##########
@@ -31,11 +31,12 @@
)
if TYPE_CHECKING:
- from statsd import StatsClient
+ from statsd import StatsClient, UnixSocketStatsClient
from .protocols import DeltaType
from .validators import ListValidator
+
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]