ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't
get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363866560
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -253,7 +253,8 @@ def _value_is_hardcoded_default(cls, attrname: str, value:
Any) -> bool:
default. (This is because ``"default" is "default"`` will be False as
they are different strings with the same characters.)
"""
- if attrname in cls._CONSTRUCTOR_PARAMS and
cls._CONSTRUCTOR_PARAMS[attrname].default is value:
+ if attrname in cls._CONSTRUCTOR_PARAMS and \
+ (cls._CONSTRUCTOR_PARAMS[attrname].default is value or (value
in [{}, []])):
Review comment:
If something has a default of None and a user explicitly passes in None,
does this change now mean we store it sa `null` in the JSON?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
