kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't 
get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363879214
 
 

 ##########
 File path: airflow/utils/decorators.py
 ##########
 @@ -64,7 +64,7 @@ def wrapper(*args, **kwargs):
             dag_args = copy(dag.default_args) or {}
             dag_params = copy(dag.params) or {}
 
-        params = kwargs.get('params', {})
+        params = kwargs.get('params', {}) or {}
 
 Review comment:
   
https://github.com/apache/airflow/pull/7092/files#diff-beca6224080086e983c4dd9649fca3feR416
 would fail if someone removes `or {}` so yes it is covered. 
   
   I can add a separate test in `test/utils/test_decorator.py` if you think 
that would be good

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to