1fanwang commented on code in PR #66805:
URL: https://github.com/apache/airflow/pull/66805#discussion_r3772746169
##########
shared/observability/src/airflow_shared/observability/metrics/otel_logger.py:
##########
@@ -507,16 +512,21 @@ def get_otel_logger(
except (ImportError, AttributeError):
pass
+ # Order matters: OTel applies views in sequence, so the name-pattern views
+ # must follow the instrument-type baseline to override it for matching
names.
+ histogram_views: list[View] = [
+ View(
+ instrument_type=metrics.Histogram,
+ aggregation=ExponentialBucketHistogramAggregation(),
+ ),
+ *build_views_for_patterns(),
+ ]
Review Comment:
Good catch, just checked otel SDK 1.44.0: `_handle_view_instrument_match`
already appends a match per matching view, no override needed. Closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
