Lee-W commented on code in PR #71643:
URL: https://github.com/apache/airflow/pull/71643#discussion_r3796472991
##########
providers/google/tests/unit/google/cloud/sensors/test_bigtable.py:
##########
@@ -126,7 +126,8 @@ def test_wait_ready(self, mock_hook):
gcp_conn_id=GCP_CONN_ID,
impersonation_chain=IMPERSONATION_CHAIN,
)
- assert op.poke(None)
+ # Only this path reaches BigtableTablesLink.persist, which does
context["ti"].xcom_push().
+ assert op.poke(mock.MagicMock())
Review Comment:
or should we make a context instead? also should we check whether this mock
is called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
