ramitkataria commented on code in PR #71646:
URL: https://github.com/apache/airflow/pull/71646#discussion_r3799738622
##########
providers/amazon/tests/unit/amazon/aws/operators/test_neptune.py:
##########
@@ -54,6 +59,31 @@ def _create_cluster(hook: NeptuneHook):
raise ValueError("AWS not properly mocked")
[email protected](
+ ("operator_class", "trigger_class"),
+ [
+ (NeptuneStartDbClusterOperator, NeptuneClusterAvailableTrigger),
+ (NeptuneStopDbClusterOperator, NeptuneClusterStoppedTrigger),
+ ],
+)
[email protected](NeptuneHook, "conn")
+def test_deferred_trigger_receives_region_name(mock_conn, operator_class,
trigger_class):
Review Comment:
Maybe we should check for all the params instead of just region?
##########
providers/amazon/tests/unit/amazon/aws/triggers/test_neptune.py:
##########
@@ -30,6 +30,22 @@
from airflow.triggers.base import TriggerEvent
CLUSTER_ID = "test-cluster"
+REGION_NAME = "eu-west-2"
+
+
[email protected](
+ "trigger_class",
+ [
+ NeptuneClusterAvailableTrigger,
+ NeptuneClusterStoppedTrigger,
+ NeptuneClusterInstancesAvailableTrigger,
+ ],
+)
+def test_region_name_reaches_the_hook_configuration(trigger_class):
Review Comment:
Here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
